Use one function for verifying negative reports

src/negative_report.rs

@@ -85,25 +85,24 @@ impl NegativeReport {
         }
     }
 
-    /// Verify report if proof of bridge knowledge is bridge line hash
+    /// Verify report. Caller must pass Some of the bridge knowledge proof type
-    pub fn verify_with_hash_of_bridge_line(self, bl: &BridgeLine) -> bool {
+    /// in the report.
+    pub fn verify(self, bl: Option<&BridgeLine>, bucket: Option<&Scalar>) -> bool {
         match self.bridge_pok {
-            ProofOfBridgeKnowledge::HashOfBridgeLine(pok) => {
+            ProofOfBridgeKnowledge::HashOfBridgeLine(pok) => match bl {
-                let hash = HashOfBridgeLine::new(bl);
+                Some(b) => {
-                hash == pok
+                    let hash = HashOfBridgeLine::new(b);
-            }
+                    hash == pok
-            _ => false,
+                }
-        }
+                None => false,
-    }
+            },
-
+            ProofOfBridgeKnowledge::HashOfBucket(pok) => match bucket {
-    /// Verify report if proof of bridge knowledge is bucket hash
+                Some(b) => {
-    pub fn verify_with_hash_of_bucket(self, bucket: &Scalar) -> bool {
+                    let hash = HashOfBucket::new(b);
-        match self.bridge_pok {
+                    hash == pok
-            ProofOfBridgeKnowledge::HashOfBucket(pok) => {
+                }
-                let hash = HashOfBucket::new(bucket);
+                None => false,
-                hash == pok
+            },
-            }
-            _ => false,
         }
     }
 }