From 10ff088b5a92a8aaab8aa9db379d0122f4fee427 Mon Sep 17 00:00:00 2001
From: Vecna <vvecna@uwaterloo.ca>
Date: Fri, 26 Apr 2024 15:25:56 -0400
Subject: [PATCH] Resolve some TODOs

---
 src/analysis.rs   | 1 -
 src/extra_info.rs | 2 +-
 src/lib.rs        | 8 ++------
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/analysis.rs b/src/analysis.rs
index 031b942..cb49a4f 100644
--- a/src/analysis.rs
+++ b/src/analysis.rs
@@ -52,7 +52,6 @@ pub fn blocked_in(
     confidence: f64,
     date: u32,
 ) -> HashSet<String> {
-    // TODO: Re-evaluate past days if we have backdated reports
     let mut blocked_in = HashSet::<String>::new();
     let today = date;
     let age = today - bridge_info.first_seen;
diff --git a/src/extra_info.rs b/src/extra_info.rs
index 88c8306..0886cd4 100644
--- a/src/extra_info.rs
+++ b/src/extra_info.rs
@@ -25,7 +25,7 @@ pub struct ExtraInfo {
     /// Map of country codes and how many users (rounded up to a multiple of
     /// 8) have connected to that bridge during the day.
     /// Uses BTreeMap instead of HashMap so ExtraInfo can implement Hash.
-    pub bridge_ips: BTreeMap<String, u32>, // TODO: What size for count?
+    pub bridge_ips: BTreeMap<String, u32>,
 }
 
 impl ExtraInfo {
diff --git a/src/lib.rs b/src/lib.rs
index 0e3e869..6dade5d 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -486,12 +486,10 @@ pub async fn update_negative_reports(db: &Db, distributors: &BTreeMap<BridgeDist
                 .unwrap();
         }
     }
-    // TODO: Would it be cheaper to just recreate it?
-    all_negative_reports.clear();
     // Remove the now-processed reports from the database
     db.insert(
         "nrs-to-process",
-        bincode::serialize(&all_negative_reports).unwrap(),
+        bincode::serialize(&BTreeMap::<String, Vec<SerializableNegativeReport>>::new()).unwrap(),
     )
     .unwrap();
 }
@@ -601,12 +599,10 @@ pub async fn update_positive_reports(db: &Db, distributors: &BTreeMap<BridgeDist
                 .unwrap();
         }
     }
-    // TODO: Would it be cheaper to just recreate it?
-    all_positive_reports.clear();
     // Remove the now-processed reports from the database
     db.insert(
         "prs-to-process",
-        bincode::serialize(&all_positive_reports).unwrap(),
+        bincode::serialize(&BTreeMap::<String, Vec<SerializablePositiveReport>>::new()).unwrap(),
     )
     .unwrap();
 }