From 20511632e82f25450fd74476eb49d4c66af5ff1e Mon Sep 17 00:00:00 2001
From: onyinyang <onyinyang@torproject.org>
Date: Mon, 19 Jul 2021 15:36:37 +0000
Subject: [PATCH] Fixed bug that still blocked spares

---
 crates/lox-library/src/tests.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/crates/lox-library/src/tests.rs b/crates/lox-library/src/tests.rs
index 95f197a..c541ea1 100644
--- a/crates/lox-library/src/tests.rs
+++ b/crates/lox-library/src/tests.rs
@@ -1396,12 +1396,13 @@ fn stats_test_blockage_migration_100() {
 /// bucket list.
 
 fn block_bridges(th: &mut TestHarness, percentage: usize, credentials: Vec<cred::Lox>) {
-    let to_block: usize = ((th.ba.bridge_table.buckets.len() - th.ba.bridge_table.spares.len()) * percentage / 100).into();
+    let blockable_bridges = th.ba.bridge_table.buckets.len() - th.ba.bridge_table.spares.len();
+    let to_block: usize = (blockable_bridges * percentage / 100).into();
     let mut block_index: HashSet<usize> = HashSet::new();
     let mut rng = rand::thread_rng();
 
     while block_index.len() <= to_block - 1 {
-        let rand_num = rng.gen_range(0, th.ba.bridge_table.buckets.len());
+        let rand_num = rng.gen_range(0, blockable_bridges);
         block_index.insert(rand_num);
     }